6.5.x: Unpin pyzmq

[minrk]

temporary pin applied to both jupyter-client 8 and pyzmq 25 in #6749 appears resolved with jupyter-client 7.4.9 (or jupyter-core 5.3.2?), at least in terms of pyzmq.

I tried to follow all of the examples in #6721 with pyzmq 25.1.2 and saw no errors, but can't be completely sure.

Pinning down pyzmq prevents installation of notebook (and thereby jupyterlab 3 and others) on Python 3.12, since pyzmq 25.1 is the first version to support 3.12, so there's a real cost to keeping a pin here if the problem is fixed elsewhere.

[jtpio]

cc @RRosio @ericsnekbytes this looks like something we might want to get in a 6.5.x release. Not sure about the CI failures though

[RRosio]

Thank you for the ping @jtpio! It looks like the CI failures are not related to this change in particular. I can merge this and try addressing at least some of those in a follow-up PR.

The test_check seems to be a rule for branch protection but since its status is still Expected, I am wondering if there is another way I can still try merging?

[jtpio]

Thanks!

I think we can ignore the failing checks for this particular PR to move forward with this fix.

[jtpio]

@RRosio if you would like to try making a release with the releaser, hopefully it will still work for that branch

[RRosio]

Thank you @jtpio, it looks like I cannot use Jupyter Releaser
.

Would it be best to continue with the manual release instructions?: https://github.com/jupyter/notebook/blob/6.5.x/RELEASE.md

Although, I was thinking I will not be able to push the commits and tags due to the expected status check.

[jtpio]

@RRosio maybe it's possible to use the workflow from the main branch, and specify 6.5.x for the target branch?

Normally the release bot should be able to push to the branch and bypass the branch protection rule.

[RRosio]

Thank you @jtpio, I was able to try running the workflow, however it looks like I do not have the permissions so the run failed: https://github.com/jupyter/notebook/actions/runs/8745004773/job/23999102632

[jtpio]

@RRosio Thanks for trying. I just added you to the repo with hopefully the correct permissions to run the workflow.

[RRosio]

The final release can be found here: https://github.com/jupyter/notebook/releases/tag/v6.5.7