Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

traitlets.warn is private, use warnings.warn #6842

Closed
wants to merge 1 commit into from

Conversation

manics
Copy link
Contributor

@manics manics commented Apr 17, 2023

As pointed out by @blink1073 in jupyterhub/jupyterhub#4418 traitlets.warn is private. The signature of the traitlets.warn method changed in ipython/traitlets#838 which means notebook 6.* will break when traitlets is next released.

This switches to the standard warnings.warn instead.

@manics
Copy link
Contributor Author

manics commented Apr 17, 2023

Oops, just seen #6840 ... should've checked first!

@manics manics closed this Apr 17, 2023
@manics manics deleted the dont-use-traitlets-warn branch April 17, 2023 20:02
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant