Fix spurious kernel selection dialog on notebook creation (#7258)

* Fix spurious kernel selection dialog on notebook creation * fix snapshots
jupyter · Feb 13, 2024 · b8ec7e4 · b8ec7e4
1 parent 9348f1f
commit b8ec7e4
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/packages/docmanager-extension/src/index.ts b/packages/docmanager-extension/src/index.ts
@@ -58,8 +58,10 @@ const opener: JupyterFrontEndPlugin<IDocumentWidgetOpener> = {
             widgetName.includes('Notebook')
           ) {
             // make sure to save the notebook before opening it in a new tab
-            // so the kernel info is saved
-            await widget.context.save();
+            // so the kernel info is saved (if created from the New dropdown)
+            if (widget.context.sessionContext.kernelPreference.name) {
+              await widget.context.save();
+            }
             route = 'notebooks';
           }
           // append ?factory only if it's not the default

diff --git a/ui-tests/test/mobile.spec.ts-snapshots/notebook-chromium-linux.png b/ui-tests/test/mobile.spec.ts-snapshots/notebook-chromium-linux.png
diff --git a/ui-tests/test/mobile.spec.ts-snapshots/notebook-firefox-linux.png b/ui-tests/test/mobile.spec.ts-snapshots/notebook-firefox-linux.png