Make hashing independent of notebook content #1774
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, changing the content of a submitted notebook breaks feedback distribution (see some discussion in #1202). This is because feedback distribution uses a hash that depends on the notebook content.
This pr aims to solve this issue by duplicating the
timestamp.txt
mechanism. Asubmission_secret.txt
file containing a random string is created during submission, and the notebook hash is changed to depend only on this file and notebook name.Should fix #1712