New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assignment names breaking regex #1768
Conversation
Added a test for correct behavior Adapts timeout in tests to avoid cancelled nbextension tests In tests: (1) updates python (drop 3.7 and includes 3.11), and (2) update ubuntu from 20.04 to 22.04 Revert "Remove an errant commented line" This removes the concept of replacing 'bad characters', and bans them Revert "Change from excluding characters to swapping for high-order Unicode versions" This actually does do the replace swap with ban thing
Thanks @perllaghu. I wonder if there could not be a way to manage special characters when running the regex match. Something like |
On my side there is some confusion in this PR, I see some modifications already in the branch |
This is essentially an extension of the existing routine - which prevent |
I'll rebase on master :) |
Just a heads up, you can review notebook changes like this using GitNotebooks. e.g. this pull request https://gitnotebooks.com/jupyter/nbgrader/pull/1768 It's free for public repos, so might be helpful for y'all. |
The last commit 88915ab is very confusing: it includes changes from 6706939 (in Please do an interactive rebase, drop the reverted commits, squash corrections into previous commits and overall make sure that this pull request can be properly reviewed. |
Agree, let's move forward with this PR and open an issue to allow these character in future development. |
The sane move now will be to drop this & redo the work on a fresh |
This extends the list of banned assignment-name characters beyond
+
to include a bunch that break the path regex code.closes #1738