Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Vidar as new Jupyter Server SSC Representative #759

Merged
merged 2 commits into from
May 15, 2024
Merged

Add Vidar as new Jupyter Server SSC Representative #759

merged 2 commits into from
May 15, 2024

Conversation

Zsailer
Copy link
Member

@Zsailer Zsailer commented May 10, 2024

@JohanMabille
Copy link
Member

JohanMabille commented May 13, 2024 •
edited

LGTM, let's @vidartf have a look and check everything is correct on his side before merging.

@ivanov ivanov mentioned this pull request May 13, 2024
Merged
vidartf
vidartf reviewed May 14, 2024
View reviewed changes
about.html Outdated Show resolved Hide resolved
vidartf
vidartf approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@vidartf vidartf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with minor naming tweak 👍

@jasongrout @vidartf
Update about.html
cf3ef86 
Co-authored-by: Vidar Tonaas Fauske <vidartf@gmail.com>
jasongrout
jasongrout approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@jasongrout jasongrout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@jasongrout
Copy link
Member

Looks like the check links test is failing for unrelated reasons.

@jasongrout jasongrout mentioned this pull request May 15, 2024
Merged
@jasongrout jasongrout merged commit 8d83327 into jupyter:main May 15, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasongrout jasongrout jasongrout approved these changes

@vidartf vidartf vidartf approved these changes

@JohanMabille JohanMabille JohanMabille approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Zsailer @JohanMabille @jasongrout @vidartf