Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customize RSA key import and JWKs endpoint response via hooks #407

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

namanshenoy
Copy link

This update allows users of the plugin to set up custom retrieval of RSA keys used to encode/decode ID tokens.

@namanshenoy namanshenoy marked this pull request as draft July 17, 2023 10:06
@namanshenoy namanshenoy force-pushed the master branch 2 times, most recently from b1cb7f6 to 8f173f2 Compare July 17, 2023 10:23
@namanshenoy namanshenoy changed the title OIDC_CLIENT_ALG_KEYS_HOOK specification Customize RSA key import and JWKs endpoint response via hooks Jul 17, 2023
@namanshenoy namanshenoy marked this pull request as ready for review July 17, 2023 10:50
@namanshenoy namanshenoy changed the base branch from master to develop July 18, 2023 18:59
Naman Shenoy and others added 2 commits July 18, 2023 11:59
This update allows users of the plugin to set up custom retrieval of RSA keys used to encode/decode ID tokens.
Copy link
Owner

@juanifioren juanifioren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need tests.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version changes are not allowed in PRs.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Settings doc should be easy to read and contain the less code possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants