Explicitly state our argument separator when calling http_build_query(). #43452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the PHP arg_separator.input configuration option is not set to & (e.g. if it's set to &) then this will result in malformed encoded strings. Sometimes this is generally OK, but when using http_build_query() to format POST data (e.g. in the Http/Transport classes) this can result in malformed POSTs and failing APIs This is easily seen in e.g. reCaptcha verification requests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the PHP arg_separator.input configuration option is not set to & (e.g. if it's set to &) then this will result in malformed encoded strings. Sometimes this is generally OK, but when using http_build_query() to format POST data (e.g. in the Http/Transport classes) this can result in malformed POSTs and failing APIs
This is easily seen in e.g. reCaptcha verification requests.
Summary of Changes
This is a long overdue rebase of #23616
Testing Instructions
Simply set arg_separator.input to & in php.ini and attempt to use reCaptcha
Actual result BEFORE applying this Pull Request
It will fail with a malformed request
Expected result AFTER applying this Pull Request
It will work.