Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] CMSPlugin: Deprecate use of DispatcherAware and LanguageAware #43430

Open
wants to merge 5 commits into
base: 5.2-dev
Choose a base branch
from

Conversation

Fedik
Copy link
Member

@Fedik Fedik commented May 6, 2024

Summary of Changes

Deprecate use of DispatcherAware and LanguageAware within CMSPlugin class.

Plugin should use DispatcherAware it on its own.
And LanguageAware is a leftover from some changes in past, and does not used anywhere (I did not found).

Partial alternative to:

Testing Instructions

Code review.
Navigate around the site.
Edit site content.
Use finder indexer.
All should work as before.

Actual result BEFORE applying this Pull Request

Works

Expected result AFTER applying this Pull Request

Works

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org: TBD
  • No documentation changes for manual.joomla.org needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants