[5.2] Smart Search: Fix URL with highlight query #43398
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
When the route of an entry in Smart Search isn't a query string, the highlight feature actually can produce invalid URLs. This PR enforces these URLs to be correct.
Testing Instructions
Look at #43397, apply that patch and get the testing plugin. Index an RTF file and search in the frontend for this entry in the search. Click on the URL.
Actual result BEFORE applying this Pull Request
The URL looks something like
/tolstoy.rtf&highlight=bunchofbase64gibberishand throws a 404 when clicked.Expected result AFTER applying this Pull Request
The URL looks something like
/tolstoy.rtf?highlight=bunchofbase64gibberishand does not throw a 404 when clicked.Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed