Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] Deprecate HTMLHelper::script(), HTMLHelper::stylesheet(), extend lifetime for Document style/script methods #43396

Open
wants to merge 7 commits into
base: 5.2-dev
Choose a base branch
from

Conversation

Fedik
Copy link
Member

@Fedik Fedik commented Apr 28, 2024

Pull Request for Issue # .

Summary of Changes

Deprecate HTMLHelper::script(), HTMLHelper::stylesheet().
Extend lifetime for Document style/script methods, because they cannot be removed before HTMLHelper::script(), HTMLHelper::stylesheet().

Add a new method HTMLHelper::mediaPath(), because we still need to lookup for overides.
Kind of temporary solution, until someone will come up with improvements to our media override API.

Testing Instructions

Apply patch. Make sure all works as before.

Add media/templates/administrator/atum/css/user.css to atum template, and make sure it still works.

Actual result BEFORE applying this Pull Request

Works

Expected result AFTER applying this Pull Request

Works

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org: TBD
  • No documentation changes for manual.joomla.org needed

@Fedik Fedik added the Feature label Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants