-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix - Do not split abspath with dot #1364
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportBase: 93.96% // Head: 93.95% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1364 +/- ##
==========================================
- Coverage 93.96% 93.95% -0.02%
==========================================
Files 52 52
Lines 7291 7291
==========================================
- Hits 6851 6850 -1
- Misses 440 441 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
The doc build failed because of an URL not reached: |
Ok i think that some generated code in readthedocs tries to load a csv from an extrernal source (url) but fails since the server send a 104 error... I have no idea how to track this since I don't know where the code is generated. If one has any clue about that... |
Could you please try to craft a minimal non-regression test for this fix? |
Let's ignore the readthedocs failure for now. If it still happens let's fix it in an dedicated PR and keep this PR focused on the original issue. |
Ok, fine for me. |
To complete @ogrisel's remark in #1364 (comment) here is scikit-learn's section on crafting minimal reproducer. A non-regression test can then be added in this PR using this reproducer. |
Here is a minimal reproducer using shell command on linux with anaconda for setting the virtual environnement:
Expected result: Actual result: I am crafting a non regression test now. |
Hello,
Following issue #1362, this improvement avoid splitting the absolute path whenever a dot is found in it. Let's say that a folder in this path is named name.folder, then the test
test_parallel_call_cached_function_defined_in_jupyter
does not pass. Plus it create an extra level in the tree structure of backend store.Let me know if there is a problem with that.
Thank you!