Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Distribution to public exports #1027

Closed
wants to merge 1 commit into from

Conversation

AKuederle
Copy link
Contributor

No description provided.

@jmschrei
Copy link
Owner

I'll need to think about this for a little bit. I use the underscore to indicate a pseudo-private method/class in the sense that the method is not meant to be directly used itself but, rather, is used internally. So, the Distribution object is not meant to be used by itself in the same way that one would use a Normal distribution. If you want to define a new distribution you'd inherit from it in the same way you'd have to implement your own pseudo-private methods.

@jmschrei
Copy link
Owner

I'm going to close this for now. Thanks for looking closely at the code and making this suggestion, though. I'll keep it in mind and if it makes sense in the future I'll add it in, though!

@jmschrei jmschrei closed this Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants