Fix hmm fit shape check #1019
Merged
Fix hmm fit shape check #1019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s will be raised and will not result into falling back to the next input shape case
|
Nice! Very thorough PR. Happy to merge this, but would you mind changing the variable name from |
Done :) |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal on how to fix #1018 .
It basically forwards the number of states to
partition_sequenceto check the correct shape for the priors.So far I only tested that this will not raise an error. I did not check, if the priors are used correctly in training.
Note: This also includes the fix proposed in #1017. If this PR is merged #1017 can be closed. If #1017 is merged separably, this PR needs to be rebased