feat(codec-selection): Use the new codec selection API #2520
+325
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w3ctag/design-reviews#836. This allows the client to seamlessly switch between the codecs without having to trigger a renegotiation. This feature is behind the flag testing.enableCodecSelectionAPI in config.js
The video codec for the local video sources needs to identified differently now, from the codecs field in the RTCRtpSendParameters returned by the browser. We no longer munge the remote SDP to switch to a different codec.
…election mechanism.
jallamsetty1
force-pushed
the
feat/new-select-codec
branch
from
7d3182e
to
dae2f11
Compare
If no 'screenshareCodec' is set under videoQuality or p2p settings, AV1 will be selected as default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
w3ctag/design-reviews#836. This allows the client to seamlessly switch between the codecs without having to trigger a renegotiation. This feature is behind the flag testing.enableCodecSelectionAPI in config.js
This is marked WIP since we need a JVB change for this feature to work as expected for all codecs. When the DD header extension headers are negotiated, Chrome includes the layer information for VP8 in the DD extension headers but the bridge currently reads this from the VP8 packet headers. Since renegotiation cycle is not triggered when this feature is enabled, client doesn't have a way of removing the DDs from being sent by Chrome when we switch to VP8. - this has been fixed in jitsi/jitsi-videobridge#2136