Expose track.conference field in types
#2518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Local and remote Jitsi tracks expose a reference to the `JitsiConference` through `track.conference`. This was not available in the TypeScript definitions. Local tracks are initialized with `conference = null` but will be set later, assuming the caller adds the track to a conference. Remote tracks are always associated with a conference.
|
Hi, thanks for your contribution! |
|
We should already have a CCLA signed for CoScreen/Datadog. Let me know if there's anything missing on our end. |
saghul
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a field
jitsiTrack.conferencethat keeps a reference to the track's owning conference. It does not have a corresponding TypeScript definition. This PR adds a type definition.JitsiLocalTrack.conference:nullif it hasn't been added to a conference yetJitsiRemoteTrack.conference: non-nullable, always associated with a conference(We're using this in our application.)