fix: add required events dependency for browser environments #1841
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for your contribution! |
saghul
approved these changes
Jan 11, 2022
|
Jenkins please test this please. |
|
OOps, sorry this one got lost, can you PL rebase? |
Abhishek260305
added a commit
to Abhishek260305/lib-jitsi-meet
that referenced
this pull request
May 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently lib-jitsi-meet imports
eventsbut it's not defined in the package.json. The IDE thinks it imports the built-in module of node.js but webpack actually resolves it as theeventspackage which is installed as a dependency of webpack itself. This PR clarifies which module is actually imported.