Skip to content

Commit

Permalink
fix(xmpp) catch errors in XMPP session resumption
Browse files Browse the repository at this point in the history
In RN, an uncaught exception causes the app to crash in release builds.
We sidestep that on the native side, but RN SDK users usually don't, so
be gracefull.

Fixes: jitsi/jitsi-meet#14728
Fixes: jitsi/jitsi-meet#14399
  • Loading branch information
saghul committed May 9, 2024
1 parent ec98b02 commit 0d8b0b8
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion modules/xmpp/ResumeTask.js
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,11 @@ export default class ResumeTask {

this._stropheConn.service = url.toString();

streamManagement.resume();
try {
streamManagement.resume();
} catch (e) {
logger.error('Failed to resume XMPP connnection', e);
}
}

/**
Expand Down

0 comments on commit 0d8b0b8

Please sign in to comment.