Implement Servlet 6.1 Error dispatch changes #11821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gregw
commented
May 20, 2024
gregw
commented
- Error dispatches are done as GET methods
- New ERROR_METHOD and ERROR_QUERY_STRING attributes
- Moved most error attributes to Dispatcher.ErrorRequest
- removed duplicate attributes
+ Error dispatches are done as GET methods + New ERROR_METHOD and ERROR_QUERY_STRING attributes + Moved most error attributes to Dispatcher.ErrorRequest + removed duplicate attributes
lachlan-roberts
approved these changes
May 21, 2024
jetty-ee11/jetty-ee11-servlet/src/main/java/org/eclipse/jetty/ee11/servlet/ServletChannel.java
Show resolved
Hide resolved
...1/jetty-ee11-servlet/src/main/java/org/eclipse/jetty/ee11/servlet/ErrorPageErrorHandler.java
Outdated
Show resolved
Hide resolved
janbartel
reviewed
May 21, 2024
jetty-ee11/jetty-ee11-servlet/src/main/java/org/eclipse/jetty/ee11/servlet/ErrorHandler.java
Outdated
Show resolved
Hide resolved
…ee11/servlet/ErrorHandler.java Co-authored-by: Jan Bartel <janb@webtide.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.