Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge recent changes from the master branch into element_parser branch #147

Open
wants to merge 73 commits into
base: element_parser
Choose a base branch
from

Conversation

a1s
Copy link

@a1s a1s commented Sep 3, 2013

No description provided.

Barry Coughlan and others added 30 commits September 5, 2012 12:05
Whitespace after key name in attribute syntax throws an exception
Command line options for hamlpy-watcher
Add a new line after the closing conditional comment
--attr-wrapper option for command line and HAMLPY_ATTR_WRAPPER setting for Django
Fix for watcher options that broke in pull request jessemiller#106
Fix jessemiller#114 HamlPyExtension filename extension check invalid
jessemiller and others added 28 commits March 5, 2013 19:54
…o Naddiseo-jinja_compat

Conflicts:
	hamlpy/hamlpy_watcher.py
Documented :stylus, :coffeescript; fixed documentation for :css
Updated reference.md (:stylus, :coffeescript, :css)
* addresses Issue jessemiller#132
* include dependent functionality only if the required package
  is available
* duplicate TemplateDoesNotExist() if django is not present
* add `NotAvailableError` for nodes which depend on non-present
  packages
* move pygments_filter test into template tests
* fix test for Pygments version 1.6
	 Output local time instead of gmttime in hamlpy_watcher when in verbose mode
Remove strict dependencies on django, pygments, markdown, jinja2
…ttributes

Allow attributes to contain any letter at all (not just ascii)
make the test of non-ascii filenames actually pass, by marking strings as unicode
I missed the note about how to run the unit tests when submitting this patch, and it turns out the test actually failed. Just needed to mark the appropriate strings as unicode to get it to work.
Fix Markdown br bug
Thanks to @boscoh for the following:
In the `:markdown` filter, the markdown for implicit `<br>` tag is broken.

The reason is that markdown recognises a line with  `<br>` by two trailing spaces.

However, trailing spaces are stripped when `PlaintextNode.haml` is read.

To fix: when the text is reconstructed to send to the Markdown filter, instead of using the `PlaintextNode.haml` field, `PlaintextNode.raw_haml.lstrip()` is used, which keeps the trailing spaces.
Fix to templatize decorator so it only hamlpy parses files with valid haml extensions see Issue jessemiller#96
@Psycojoker
Copy link

Hello,

As this repository sadly doesn't seems to be maintained anymore (it's been 3 years now), I've forked it, integrated this patch and upload it on pypi under django-hamlpy. You can find the result here: https://github.com/Psycojoker/django-hamlpy

I'm looking for a third co-maintainer (to avoid having an unmaintained project again), ideally someone that wishes to use it with the jinja2 part of django but that's not mandatory.

@jessemiller if you ever come back to hamlpy feel free to join :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet