New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sp/gr #11600
base: master
Are you sure you want to change the base?
Sp/gr #11600
Conversation
Changes in OpenAPI specification found. Expand to see details.What's Changed
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This at a minimum requires testing whether migrations are required for the plugin manifests, and depending on how a unknown value is handled, I think it might be required.
I am not sure of how and if clients are using this enum, but it is likely that at least jellyfin-web needs to be updated for this change.
Further, I would like to point out that supercede seems to be fairly widely used, even if often considered a misspelling, and has according to Wikitionary been in use in English since the 1400s. Merriam-Webster lists it as a spelling variant, albeit disputed. Dictionary.com also has a entry, if only to point it out as «a frequent misspelling of supersede». It is also listed as a synonym in other online dictionaries, such as Vocabulary.com.
Due to the above points, I question the usefulness of this change
I think at the least that the function name |
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged. |
Latin root: sedere - to sit (compare: sedentary) Consider: cede: to give up or yield; supercede; to super give up?
https://www.dictionary.com/browse/supersede
Latin root: sedere - to sit (compare: sedentary)
Consider: cede: to give up or yield; supercede; to super give up?
We're also not in the car business, I hope.