Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sp/gr #11600

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Sp/gr #11600

wants to merge 1 commit into from

Conversation

systemcrash
Copy link

https://www.dictionary.com/browse/supersede

Latin root: sedere - to sit (compare: sedentary)

Consider: cede: to give up or yield; supercede; to super give up?

We're also not in the car business, I hope.

Copy link

Changes in OpenAPI specification found. Expand to see details.

What's Changed


GET /Plugins
Return Type:

Changed response : 200 OK

Installed plugins returned.

  • Changed content type : application/json

Changed items (object):

This is a serializable stub class that is used by the api to provide information about installed plugins.

openapi-base openapi-changes.md openapi-head Changed property Status (string)

Gets or sets a value indicating the status of the plugin.

Updated PluginStatus :
Added enum value:

openapi-base openapi-changes.md openapi-head Superseded
Removed enum value:

openapi-base openapi-changes.md openapi-head Superceded
Added enum value:

openapi-base openapi-changes.md openapi-head Superseded
Removed enum value:

openapi-base openapi-changes.md openapi-head Superceded

  • Changed content type : application/json; profile="CamelCase"

Changed items (object):

This is a serializable stub class that is used by the api to provide information about installed plugins.

openapi-base openapi-changes.md openapi-head Changed property Status (string)

Gets or sets a value indicating the status of the plugin.

Updated PluginStatus :
Added enum value:

openapi-base openapi-changes.md openapi-head Superseded
Removed enum value:

openapi-base openapi-changes.md openapi-head Superceded
Added enum value:

openapi-base openapi-changes.md openapi-head Superseded
Removed enum value:

openapi-base openapi-changes.md openapi-head Superceded

  • Changed content type : application/json; profile="PascalCase"

Changed items (object):

This is a serializable stub class that is used by the api to provide information about installed plugins.

openapi-base openapi-changes.md openapi-head Changed property Status (string)

Gets or sets a value indicating the status of the plugin.

Updated PluginStatus :
Added enum value:

openapi-base openapi-changes.md openapi-head Superseded
Removed enum value:

openapi-base openapi-changes.md openapi-head Superceded
Added enum value:

openapi-base openapi-changes.md openapi-head Superseded
Removed enum value:

openapi-base openapi-changes.md openapi-head Superceded

Copy link
Member

@oddstr13 oddstr13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This at a minimum requires testing whether migrations are required for the plugin manifests, and depending on how a unknown value is handled, I think it might be required.

I am not sure of how and if clients are using this enum, but it is likely that at least jellyfin-web needs to be updated for this change.

Further, I would like to point out that supercede seems to be fairly widely used, even if often considered a misspelling, and has according to Wikitionary been in use in English since the 1400s. Merriam-Webster lists it as a spelling variant, albeit disputed. Dictionary.com also has a entry, if only to point it out as «a frequent misspelling of supersede». It is also listed as a synonym in other online dictionaries, such as Vocabulary.com.

Due to the above points, I question the usefulness of this change

@holow29
Copy link
Contributor

holow29 commented May 13, 2024

I think at the least that the function name UpdatePluginSuperceedStatus should at least match the enum value name PluginStatus.Superceded. Superceed is wrong no matter what one thinks of supercede vs. supersede and it is not uniform in the code.

@jellyfin-bot
Copy link
Contributor

This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

@jellyfin-bot jellyfin-bot added the merge conflict Merge conflicts should be resolved before a merge label May 15, 2024
Latin root: sedere - to sit (compare: sedentary)

Consider: cede: to give up or yield; supercede; to super give up?
@jellyfin-bot jellyfin-bot removed the merge conflict Merge conflicts should be resolved before a merge label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants