Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix warning CA1819 in LibraryOptions.cs #11473

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix warning CA1819 in LibraryOptions.cs #11473

wants to merge 3 commits into from
+74 −78

Conversation

gsedubun
Copy link

@gsedubun gsedubun commented May 1, 2024

Changes

change string[] properties in LibraryOptions.cs to ICollection

Issues

Fixes #2149 warning CA1819: Properties should not return arrays in LibraryOptions.cs

@jellyfin-bot jellyfin-bot added the merge conflict Merge conflicts should be resolved before a merge label May 1, 2024
@jellyfin-bot
Copy link
Contributor

This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 1, 2024

Changes in OpenAPI specification found. Expand to see details.

What's Changed

GET /Library/VirtualFolders
Return Type:

Changed response : 200 OK

Virtual folders retrieved.

  • Changed content type : application/json

Changed items (object):

Used to hold information about a user's list of configured virtual folders.

openapi-base openapi-changes.md openapi-head Changed property LibraryOptions (object)

Updated LibraryOptions :
openapi-base openapi-changes.md openapi-head Changed property MetadataSavers (array)

openapi-base openapi-changes.md openapi-head Changed property DisabledLocalMetadataReaders (array)

openapi-base openapi-changes.md openapi-head Changed property LocalMetadataReaderOrder (array)

openapi-base openapi-changes.md openapi-head Changed property DisabledSubtitleFetchers (array)

openapi-base openapi-changes.md openapi-head Changed property SubtitleFetcherOrder (array)

openapi-base openapi-changes.md openapi-head Changed property SubtitleDownloadLanguages (array)

openapi-base openapi-changes.md openapi-head Changed property PathInfos (array)

openapi-base openapi-changes.md openapi-head Changed property TypeOptions (array)

  • Changed content type : application/json; profile="CamelCase"

Changed items (object):

Used to hold information about a user's list of configured virtual folders.

openapi-base openapi-changes.md openapi-head Changed property LibraryOptions (object)

Updated LibraryOptions :
openapi-base openapi-changes.md openapi-head Changed property MetadataSavers (array)

openapi-base openapi-changes.md openapi-head Changed property DisabledLocalMetadataReaders (array)

openapi-base openapi-changes.md openapi-head Changed property LocalMetadataReaderOrder (array)

openapi-base openapi-changes.md openapi-head Changed property DisabledSubtitleFetchers (array)

openapi-base openapi-changes.md openapi-head Changed property SubtitleFetcherOrder (array)

openapi-base openapi-changes.md openapi-head Changed property SubtitleDownloadLanguages (array)

openapi-base openapi-changes.md openapi-head Changed property PathInfos (array)

openapi-base openapi-changes.md openapi-head Changed property TypeOptions (array)

  • Changed content type : application/json; profile="PascalCase"

Changed items (object):

Used to hold information about a user's list of configured virtual folders.

openapi-base openapi-changes.md openapi-head Changed property LibraryOptions (object)

Updated LibraryOptions :
openapi-base openapi-changes.md openapi-head Changed property MetadataSavers (array)

openapi-base openapi-changes.md openapi-head Changed property DisabledLocalMetadataReaders (array)

openapi-base openapi-changes.md openapi-head Changed property LocalMetadataReaderOrder (array)

openapi-base openapi-changes.md openapi-head Changed property DisabledSubtitleFetchers (array)

openapi-base openapi-changes.md openapi-head Changed property SubtitleFetcherOrder (array)

openapi-base openapi-changes.md openapi-head Changed property SubtitleDownloadLanguages (array)

openapi-base openapi-changes.md openapi-head Changed property PathInfos (array)

openapi-base openapi-changes.md openapi-head Changed property TypeOptions (array)

POST /Library/VirtualFolders
Request:

Changed content type : application/json

Updated AddVirtualFolderDto :

  • Changed property LibraryOptions (object)

Gets or sets library options.

Updated LibraryOptions :
openapi-base openapi-changes.md openapi-head Changed property MetadataSavers (array)

openapi-base openapi-changes.md openapi-head Changed property DisabledLocalMetadataReaders (array)

openapi-base openapi-changes.md openapi-head Changed property LocalMetadataReaderOrder (array)

openapi-base openapi-changes.md openapi-head Changed property DisabledSubtitleFetchers (array)

openapi-base openapi-changes.md openapi-head Changed property SubtitleFetcherOrder (array)

openapi-base openapi-changes.md openapi-head Changed property SubtitleDownloadLanguages (array)

openapi-base openapi-changes.md openapi-head Changed property PathInfos (array)

openapi-base openapi-changes.md openapi-head Changed property TypeOptions (array)

Changed content type : text/json

Updated AddVirtualFolderDto :

  • Changed property LibraryOptions (object)

Gets or sets library options.

Updated LibraryOptions :
openapi-base openapi-changes.md openapi-head Changed property MetadataSavers (array)

openapi-base openapi-changes.md openapi-head Changed property DisabledLocalMetadataReaders (array)

openapi-base openapi-changes.md openapi-head Changed property LocalMetadataReaderOrder (array)

openapi-base openapi-changes.md openapi-head Changed property DisabledSubtitleFetchers (array)

openapi-base openapi-changes.md openapi-head Changed property SubtitleFetcherOrder (array)

openapi-base openapi-changes.md openapi-head Changed property SubtitleDownloadLanguages (array)

openapi-base openapi-changes.md openapi-head Changed property PathInfos (array)

openapi-base openapi-changes.md openapi-head Changed property TypeOptions (array)

Changed content type : application/*+json

Updated AddVirtualFolderDto :

  • Changed property LibraryOptions (object)

Gets or sets library options.

Updated LibraryOptions :
openapi-base openapi-changes.md openapi-head Changed property MetadataSavers (array)

openapi-base openapi-changes.md openapi-head Changed property DisabledLocalMetadataReaders (array)

openapi-base openapi-changes.md openapi-head Changed property LocalMetadataReaderOrder (array)

openapi-base openapi-changes.md openapi-head Changed property DisabledSubtitleFetchers (array)

openapi-base openapi-changes.md openapi-head Changed property SubtitleFetcherOrder (array)

openapi-base openapi-changes.md openapi-head Changed property SubtitleDownloadLanguages (array)

openapi-base openapi-changes.md openapi-head Changed property PathInfos (array)

openapi-base openapi-changes.md openapi-head Changed property TypeOptions (array)

POST /Library/VirtualFolders/LibraryOptions
Request:

Changed content type : application/json

Updated UpdateLibraryOptionsDto :

  • Changed property LibraryOptions (object)

Gets or sets library options.

Updated LibraryOptions :
openapi-base openapi-changes.md openapi-head Changed property MetadataSavers (array)

openapi-base openapi-changes.md openapi-head Changed property DisabledLocalMetadataReaders (array)

openapi-base openapi-changes.md openapi-head Changed property LocalMetadataReaderOrder (array)

openapi-base openapi-changes.md openapi-head Changed property DisabledSubtitleFetchers (array)

openapi-base openapi-changes.md openapi-head Changed property SubtitleFetcherOrder (array)

openapi-base openapi-changes.md openapi-head Changed property SubtitleDownloadLanguages (array)

openapi-base openapi-changes.md openapi-head Changed property PathInfos (array)

openapi-base openapi-changes.md openapi-head Changed property TypeOptions (array)

Changed content type : text/json

Updated UpdateLibraryOptionsDto :

  • Changed property LibraryOptions (object)

Gets or sets library options.

Updated LibraryOptions :
openapi-base openapi-changes.md openapi-head Changed property MetadataSavers (array)

openapi-base openapi-changes.md openapi-head Changed property DisabledLocalMetadataReaders (array)

openapi-base openapi-changes.md openapi-head Changed property LocalMetadataReaderOrder (array)

openapi-base openapi-changes.md openapi-head Changed property DisabledSubtitleFetchers (array)

openapi-base openapi-changes.md openapi-head Changed property SubtitleFetcherOrder (array)

openapi-base openapi-changes.md openapi-head Changed property SubtitleDownloadLanguages (array)

openapi-base openapi-changes.md openapi-head Changed property PathInfos (array)

openapi-base openapi-changes.md openapi-head Changed property TypeOptions (array)

Changed content type : application/*+json

Updated UpdateLibraryOptionsDto :

  • Changed property LibraryOptions (object)

Gets or sets library options.

Updated LibraryOptions :
openapi-base openapi-changes.md openapi-head Changed property MetadataSavers (array)

openapi-base openapi-changes.md openapi-head Changed property DisabledLocalMetadataReaders (array)

openapi-base openapi-changes.md openapi-head Changed property LocalMetadataReaderOrder (array)

openapi-base openapi-changes.md openapi-head Changed property DisabledSubtitleFetchers (array)

openapi-base openapi-changes.md openapi-head Changed property SubtitleFetcherOrder (array)

openapi-base openapi-changes.md openapi-head Changed property SubtitleDownloadLanguages (array)

openapi-base openapi-changes.md openapi-head Changed property PathInfos (array)

openapi-base openapi-changes.md openapi-head Changed property TypeOptions (array)

@gsedubun
Merge branch 'master' into fix-CA1819-LibraryOptions
8c4419a 
Fix Conflicts:
	Emby.Server.Implementations/Library/LibraryManager.cs
	Jellyfin.Api/Controllers/LibraryStructureController.cs
@jellyfin-bot jellyfin-bot removed the merge conflict Merge conflicts should be resolved before a merge label May 1, 2024
@jumoog
Copy link

jumoog commented May 1, 2024

I think you should keep the changes made in 3feb3f8

gsedubun
gsedubun commented May 1, 2024
View reviewed changes
Emby.Server.Implementations/Library/LibraryManager.cs
@@ -3038,7 +3038,7 @@ private void AddMediaPathInternal(string virtualFolderName, MediaPathInfo pathIn
{
var libraryOptions = CollectionFolder.GetLibraryOptions(virtualFolderPath);

libraryOptions.PathInfos = [..libraryOptions.PathInfos, pathInfo];
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jumoog did you mean this?

@jellyfin-bot
Copy link
Contributor

This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

@jellyfin-bot jellyfin-bot added the merge conflict Merge conflicts should be resolved before a merge label May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merge conflict Merge conflicts should be resolved before a merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Eliminate All Compiler Warnings In Solution
3 participants
@gsedubun @jellyfin-bot @jumoog