Reduced VIdeo Controller Complexity #11300
Conversation
|
No changes to OpenAPI specification found. See history of this comment for previous changes. |
|
Please revert the API changes |
The actual API has not changed, only the auto API definition. I was hoping to bring the changes in because it has improved readability due to there only being 2 parameters rather than 10's. |
|
The casing of the query parameters has changed. |
Ill add the property name field to the model? I believe DOTNET should handle converting camelcase to Proper but leave it with me |
|
How do we get people to re review this? |
|
Just wait. This PR is extremely low priority and our focus is on 10.9 related changes at the moment. |
jellyfin-bot
added
the
merge conflict
|
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged. |
jellyfin-bot
removed
the
merge conflict
|
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged. |
jellyfin-bot
added
the
merge conflict
jellyfin-bot
removed
the
merge conflict
jellyfin-bot
added
the
merge conflict
|
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged. |
jellyfin-bot
removed
the
merge conflict
|
Hi, Ideally I would like to get this in, as it will make it easier for me to investigate 2 issues i am seeing.
|
|
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged. |
jellyfin-bot
added
the
merge conflict
jellyfin-bot
removed
the
merge conflict
Noticed when hosted in a k8s env it was holding onto memory. Cleaned up the video controller so i can dig into why it is doing so.
Looks to potentially be not disposing state/transcoding files but this will help me find out.