Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue Watching With Multiple Local Versions Fix #11285

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

SourSulfur
Copy link

@SourSulfur SourSulfur commented Apr 3, 2024

Changes

  • Assigned parent IDs to local alternate versions.
  • Used presentation unique key instead of userdatakey when fetching resumable items.

Issues
Fixes #11118

@SourSulfur
Copy link
Author

I'm not sure if there's a specific reason why the local alternate versions of a movie are not assigned a parent ID but assigning it does make them resumable.

If this is indeed a satisfactory change, I'm unsure if the place at which I handled this is ok. There might be a better place to handle this at and could use suggestions/feedback on this.

@cvium
Copy link
Member

cvium commented Apr 3, 2024

What about linked alternate versions?

@SourSulfur
Copy link
Author

What about linked alternate versions?

I'm not sure what that is and how it's different from local alternate versions, so I'm not sure how to test its behaviour. Will have to take a look.

@SourSulfur SourSulfur force-pushed the continue-watching-enhancement branch from 7c9a6e8 to 601347d Compare April 19, 2024 06:58
@jellyfin-bot
Copy link
Contributor

This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

@jellyfin-bot jellyfin-bot added the merge conflict Merge conflicts should be resolved before a merge label Apr 19, 2024
@SourSulfur SourSulfur closed this Apr 19, 2024
@SourSulfur SourSulfur force-pushed the continue-watching-enhancement branch from 601347d to c99b30a Compare April 19, 2024 07:02
@SourSulfur SourSulfur reopened this Apr 19, 2024
@jellyfin-bot jellyfin-bot removed the merge conflict Merge conflicts should be resolved before a merge label Apr 19, 2024
@SourSulfur
Copy link
Author

SourSulfur commented Apr 19, 2024

What about linked alternate versions?

My earlier changes did affect the behaviour of linked alternate versions. I scrapped those changes and went with a different approach - instead of setting the parent IDs for local alt versions and modifying the existing join, I just fetched the resumable local alt versions separately now

@SourSulfur SourSulfur marked this pull request as ready for review April 19, 2024 09:53
@SourSulfur
Copy link
Author

What about linked alternate versions?

I made some changes, any chance I can get a review?

@jellyfin-bot
Copy link
Contributor

This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

@jellyfin-bot jellyfin-bot added merge conflict Merge conflicts should be resolved before a merge and removed merge conflict Merge conflicts should be resolved before a merge labels May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue]: Continue Watching Doesn't Remember the Version Played
3 participants