New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Continue Watching With Multiple Local Versions Fix #11285
base: master
Are you sure you want to change the base?
Continue Watching With Multiple Local Versions Fix #11285
Conversation
I'm not sure if there's a specific reason why the local alternate versions of a movie are not assigned a parent ID but assigning it does make them resumable. If this is indeed a satisfactory change, I'm unsure if the place at which I handled this is ok. There might be a better place to handle this at and could use suggestions/feedback on this. |
What about linked alternate versions? |
I'm not sure what that is and how it's different from local alternate versions, so I'm not sure how to test its behaviour. Will have to take a look. |
7c9a6e8
to
601347d
Compare
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged. |
601347d
to
c99b30a
Compare
My earlier changes did affect the behaviour of linked alternate versions. I scrapped those changes and went with a different approach - instead of setting the parent IDs for local alt versions and modifying the existing join, I just fetched the resumable local alt versions separately now |
I made some changes, any chance I can get a review? |
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged. |
Changes
Issues
Fixes #11118