Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue]: Continue Watching Doesn't Remember the Version Played #11118

Open
1 task done
buzzzz2138 opened this issue Mar 7, 2024 · 6 comments · May be fixed by #11285
Open
1 task done

[Issue]: Continue Watching Doesn't Remember the Version Played #11118

buzzzz2138 opened this issue Mar 7, 2024 · 6 comments · May be fixed by #11285
Labels
bug Something isn't working enhancement Improving an existing function, or small fixes

Comments

@buzzzz2138
Copy link

Please describe your bug

I have a folder that has the following files inside of it:
'Dune.1984 - 1Original.en.srt'
'Dune.1984 - 1Original.mp4'
'Dune.1984 - 2Extended.en.srt'
'Dune.1984 - 2Extended.mp4'
'Dune.1984 - 3Bonus Disc.mp4'
'Dune.1984 - 4Alternative Edition Redux.mp4'
'Dune.1984.trailer.mp4'

Under Version I see the following.
image

Reproduction Steps

If I got into the movie and select the 2Extended Version it plays as expected. If I then stop watching and later continue watching from the home page, it starts the 4Alternative Edition Redux version.
The work around is to go into the movie page and start the continue watching with the correct version selected. Continue Watching doesn't remember the version that was played.

Jellyfin Version

10.8.13

if other:

No response

Environment

- OS: Debian 11 (Open Media Vault)
- Linux Kernel:
- Virtualization: Docker
- Clients: Firefox 123
- Browser: Firefox 123
- FFmpeg Version: Docker
- Playback Method: Continue Watching

Jellyfin logs

NA

FFmpeg logs

No response

Please attach any browser or client logs here

No response

Please attach any screenshots here

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@buzzzz2138 buzzzz2138 added the bug Something isn't working label Mar 7, 2024
@TimGels TimGels added the enhancement Improving an existing function, or small fixes label Mar 7, 2024
@jbatt33
Copy link

jbatt33 commented Apr 2, 2024

To take this enhancement a bit further, we should also be saving the last selection Audio/subtitle settings when the content is stopped.

@jbatt33
Copy link

jbatt33 commented Apr 2, 2024

Checking the data repository, we only have playbackPositionTicks storeted. We are storing the AudioStreamIndex and the SubtitleStreamIndex, but I'm not sure if these are updated when the item was started. Checking more.

Ok, I see Audio and subtitle are updated when the track changes, which makes sense. I think I need to debug this a bit more.

@SourSulfur
Copy link

SourSulfur commented Apr 3, 2024

While replicating this I've also noticed that going into the movie page and selecting the version only works if that's the only version that has been played.

So, if I play Version 1 and then resume V1 from the movie page, it resumes from the right spot. However, if I now play V2 till some other point midway and then try to resume V1 again from the movie page, it plays from V2's stop point, not V1.

I was wondering if someone else could confirm if they noticed this (maybe @buzzzz2138?) or can replicate this behavior or if there's already an issue that tracks this?

@buzzzz2138
Copy link
Author

The stop point is recorded but isn't related to the version of movie being played only the Movie page.
Play V1 to 20 minutes.
Then stop and go back to the movie page and select/play V2 and it'll start at the 20 minute mark. That reads to me that the current position time is only related to the movie as a whole and not related to the version.

@SourSulfur
Copy link

SourSulfur commented Apr 3, 2024

Yeah, I'm assuming this is a bug and the current position should be associated with each version. Not sure if there's already an issue for this if it is indeed a bug.

@Shadowghost
Copy link
Contributor

If the userdata supports differentiating between versions, it's definitly a bug. If not, it's tech debt left over from bad Emby implementations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement Improving an existing function, or small fixes
Projects
Status: Team Review
Development

Successfully merging a pull request may close this issue.

5 participants