Add csv to runtime dependency list #9522
Merged
+2
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a 🙋 feature or enhancement.
Summary
This adds csv as a dependency in the gemspec.
Context
As of Ruby 3.3.0 I was seeing this warning print to the console when running
jekyll serve
:/Users/username/.gem/ruby/3.3.0/gems/jekyll-4.3.3/lib/jekyll.rb:28: warning: csv was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add csv to your Gemfile or gemspec. Also contact author of jekyll-4.3.3 to add csv into its gemspec.
Since this was a fairly simple fix, I figured I'd just throw a PR up for it. I wasn't sure what version to require as a dependency so I just used the latest major version of csv.
I didn't think there was any tests needed for this type of change but let me know if I'm wrong on that.
Notably if we wanted, this could be a conditional dependency on the ruby version wrapped with something like: