Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add csv to runtime dependency list #9522

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Add csv to runtime dependency list #9522

merged 1 commit into from
Jan 10, 2024

Conversation

mmenanno
Copy link
Contributor

@mmenanno mmenanno commented Jan 8, 2024

This is a 🙋 feature or enhancement.

Summary

This adds csv as a dependency in the gemspec.

Context

As of Ruby 3.3.0 I was seeing this warning print to the console when running jekyll serve:

/Users/username/.gem/ruby/3.3.0/gems/jekyll-4.3.3/lib/jekyll.rb:28: warning: csv was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add csv to your Gemfile or gemspec. Also contact author of jekyll-4.3.3 to add csv into its gemspec.

Since this was a fairly simple fix, I figured I'd just throw a PR up for it. I wasn't sure what version to require as a dependency so I just used the latest major version of csv.

I didn't think there was any tests needed for this type of change but let me know if I'm wrong on that.

Notably if we wanted, this could be a conditional dependency on the ruby version wrapped with something like:

if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('3.3')
  s.add_dependency("csv", "~> 3.0")
end

@mattr- mattr- changed the title add csv to runtime dependency list Add csv to runtime dependency list Jan 10, 2024
Copy link
Member

@mattr- mattr- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this warning!

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit 25fd87c into jekyll:master Jan 10, 2024
11 checks passed
jekyllbot added a commit that referenced this pull request Jan 10, 2024
github-actions bot pushed a commit that referenced this pull request Jan 10, 2024
halorrr: add csv to runtime dependency list (#9522)

Merge pull request 9522
@mattr-
Copy link
Member

mattr- commented Jan 10, 2024

Note to self: This should get a backport to both the 4.3 and 3.9 branches

/cc @jekyll/core if someone wants to tackle the backports before I can get to it. ❤️

@dorianmariecom
Copy link

Hey, would be nice if this was released somehow, thanks for maintaining jekyll you rock

monfresh pushed a commit to monfresh/jekyll that referenced this pull request Jun 5, 2024
monfresh pushed a commit to monfresh/jekyll that referenced this pull request Jun 5, 2024
@mmenanno
Copy link
Contributor Author

mmenanno commented Jun 6, 2024

@mattr- Just giving a nudge that it looks like this still hasn't been backported yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants