Support custom streams with file name info #734
+31
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonferquel
changed the title
Many operations involved in rewriting debug symbols assume the rewritten assembly base stream is a FileStream to get file name information. This may not always be the case. To cover this, this changes the way file name is resolved so that a custom stream implementing `IHaveAFileName` can be understood by Cecil. Signed-off-by: Simon Ferquel <simon.ferquel@unity3d.com>
simonferquel
force-pushed
the
add-support-for-filename-info-in-custom-streams
branch
from
8871d88
to
94b3e71
Compare
|
To add to this: This callsite in particular will write out an empty PDB path unless you write out to a file. This is undesirable in scenarios where you modify the assembly in memory and write to a |
|
Hey folks; Yeah I know that part is horrible. Thanks for starting this discussion. I might not take this PR as is, but I'll think about how I want to fix this and get back to this PR. Thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many operations involved in rewriting debug symbols assume the rewritten
assembly base stream is a FileStream to get file name information. This
may not always be the case.
To cover this, this changes the way file name is resolved so that a
custom stream implementing
IHaveAFileNamecan be understood by Cecil.Signed-off-by: Simon Ferquel simon.ferquel@unity3d.com