#3233 UI: Common method to delete server and custom directory entries #3260

AdamGLIN · 2024-04-03T21:08:25Z

I added a horizontal box layout which include the box and the delete button. I wrote a fonction to implement the delete button.

It works well when we change the focus with the mouse to add a new directory but I can't make the enter key work : it delete the input and nothing happend. I tried to add the QLineEdit::returnPressed signal but it changed nothing. I struggle to understand the former use of the QComboBox::activated signal since I commented it and nothing seems to have changed.

TODO :
Allowing to add directory via enter key.
Improve spacers in the ui.

Short description of changes

CHANGELOG: UI: Add "Delete Entry" button to Advanced Settings, Custom Directories

Context: Fixes an issue?

#3233

Does this change need documentation? What needs to be documented and how?

Status of this Pull Request

What is missing until this pull request can be merged?

Checklist

I've verified that this Pull Request follows the general code principles
I tested my code and it does what I want
My code follows the style guide
I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
I've filled all the content above

I added a horizontal box layout which include the box and the delete button. I wrote a fonction to implement the delete button. It works well when we change the focus with the mouse to add a new directory but I can't make the enter key work : it delete the input and nothing happend. I tried to add the QLineEdit::returnPressed signal but it changed nothing. I struggle to understand the former use of the QComboBox::activated signal since I commented it and nothing seems to have changed. TODO : Allowing to add directory via enter key. Improve spacers in the ui.

ann0see · 2024-04-03T21:16:00Z

Thanks for opening this PR. It's a draft/WIP so it needs discussion. @pljones Should be most familiar with this.

ann0see · 2024-04-03T21:17:13Z

Could you please also post your questions here? Best right in the code tab close to where the question arises.

AdamGLIN · 2024-04-03T21:43:34Z

Hello,

It works for the main part, I mostly followed this commit.

However, I have some issues :

I can't figure out why the QLineEdit::editingFinished signal that we use to notify the changes, don't seems to work when I press the enter key (I read that it was supposed to). (src/clientsettingsdlg.cpp, line ~700)
I don't understand the use of the QComboBox::activated signal since I commented it and it changed nothing. Also I read that the signal was sent when the user clicks on an item of the list and I think that it was not a interesting behavior for this feature because the order doesn't matter. Tell me if I'm wrong. (src/clientsettingsdlg, line ~700)
I found out that we use the StringFiFoWithCompare method (src/util.h, line ~170) to update the list without repetition (I think) for both directories and server address lists (src/clientsettingsdlg, line ~1060). However, there is a loop introduced in this commit (src/connectdlg.cpp, line ~750) to avoid repetition, and hence it is useless. For the first change I decided just to copy the loop and not think to much about it. What do you think about it ? Did I miss something ?

I have still things to improve such as the interface (boxes are not equally spaced), but I would like your opinion to continue this way !

Thanks for your time !

softins · 2024-04-03T22:53:38Z

Thanks Adam! I started to look at your commit and questions earlier today, but got diverted onto other things. I will have a look soon, hopefully tomorrow!

src/clientsettingsdlg.cpp

src/clientsettingsdlgbase.ui

@pljones

I followed the suggestions made py @pljones and I changed a size hint of a spacer in the UI to make sure that everything is evenly spaced. TODO : Allowing adding directory via enter key

src/clientsettingsdlg.cpp

I used flags to allow the use of only one function for the delete button and the list itself, I deleted a ":" in the label (other labels didn't use ":") and I added a tabstop for the button

src/clientsettingsdlg.cpp

src/clientsettingsdlgbase.ui

I added return in case the data isn't valid. I also added a ":" to avoid translations problems.

pljones · 2024-04-16T17:15:30Z

Looks good to me, now. I've kicked off the build.

Thanks for all the time you've spent on this! :)

AdamGLIN · 2024-04-17T07:03:26Z

Thank you for your patience and your advices :)

pljones · 2024-04-17T16:43:36Z

Just tried the Windows version from the build artifacts and it looks okay to me.

ann0see · 2024-04-17T21:16:29Z

This needs some squashing and rebasing, I believe. I'll look into it once I have time.

ann0see changed the title ~~first commit to resolve the issue #3233~~ WIP: resolve #3233 Apr 3, 2024

pljones reviewed Apr 4, 2024

View reviewed changes