-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop-In Replacement for .NET Regex #9
Open
iwillspeak
wants to merge
23
commits into
main
Choose a base branch
from
drop-in
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be a simple drop-in replacement for the `System.Text.RegularExpressions` namespace (#6).
No pattern matching yet, and the options aren't mapped from .NET style flags to the Rure ones yet.
Maps the regex flags to their corresponding Rure values and implements the simplest instance method on the Regex class. Still needs work to create the static `IsMatch`. Should we cache compiled regular expressions? What about the other flags which we can't map accross properly?
iwillspeak
force-pushed
the
master
branch
5 times, most recently
from
September 16, 2017 11:55
4b0e7d9
to
4bf7185
Compare
No point trying to compile for this anywhere else.
More work replicating the standard regex classes.
# Conflicts: # bench/Alice/Alice.csproj # src/IronRure/IronRure.csproj
# Conflicts: # src/IronRure/IronRure.csproj
Fingers crossed this will prevent GitVersion from getting confused.
Config file for gitversion
Not needed right now, and seems to be fighting with the CI PR branching.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work to create a set of classes with a similar API to the .NET regex API. The aim is to be source-compatible with standard regexes to make testing out Rure easier.