wip: Update jpeg decoder. #1657
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was trying to see an xray that I got recently (happy to email it privately if it helps), which fails to decode on the demo with: ``` JPX Error: Unsupported COD options (selectiveArithmeticCodingBypass) jpx.js:339:23 ``` So this tries to update to openjpeg via mozilla/pdf.js#17946, which should support it. However: * It's very WIP (the image decodes correctly on the worker, but I only see black on the canvas, however I see correct metadata). * I haven't updated all the references to the other decoders. * It loads the non-jpeg decoders as a module which I can't test, but probably breaks them. I also need to update the sync decoders, which likely doesn't work. I don't think I'll have time to finish this, but posting it here in case it saves someone time or someone has the time to finish it up. Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to see an xray that I got recently (happy to email it privately if it helps), which fails to decode on the demo with:
So this tries to update to openjpeg via
mozilla/pdf.js#17946, which should support it. However:
I don't think I'll have time to finish this, but posting it here in case it saves someone time or someone has the time to finish it up.
Thanks.