Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create fishy.json #14029

Closed
wants to merge 7 commits into from
Closed

Create fishy.json #14029

wants to merge 7 commits into from

Conversation

skibidiloser
Copy link

@skibidiloser skibidiloser commented May 18, 2024 •
edited

Requirements

Unless explicitly specified otherwise by a maintainer or in the requirement description, your domain must pass ALL the indicated requirements above.

Please note that we reserve the rights not to accept any domain at our own discretion.

  • The file is in the domains folder and is in the JSON format.
  • You have completed your website.
  • The website is reachable.
  • You're not using Vercel or Netlify.
  • The CNAME record doesn't contain https:// or /.
  • There is sufficient information at the owner field.

Website Link/Preview

@skibidiloser skibidiloser requested review from a team as code owners May 18, 2024 14:16
CuteDog5695
CuteDog5695 requested changes May 18, 2024
View reviewed changes
domains/fishy.json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Json file literally doesn't have anything

@CuteDog5695 CuteDog5695 added the reason: invalid file Your file is invalid or improper. label May 18, 2024
CuteDog5695
CuteDog5695 requested changes May 19, 2024
View reviewed changes
domains/fishy.json Outdated Show resolved Hide resolved
domains/fishy.json Outdated Show resolved Hide resolved
@CuteDog5695 CuteDog5695 added the reason: inaccessible website Your website is not accessible to others. label May 19, 2024
skibidiloser and others added 4 commits May 19, 2024 01:38
@skibidiloser @CuteDog5695
Update domains/fishy.json
25d36ef 
Co-authored-by: CuteDog5695 <cutedog5695@gmail.com>
@skibidiloser @CuteDog5695
Update domains/fishy.json
def417a 
Co-authored-by: CuteDog5695 <cutedog5695@gmail.com>
@skibidiloser
Merge branch 'is-a-dev:main' into main
70eb9fa
@skibidiloser
Merge branch 'main' into main
53d208b
orxngc
orxngc reviewed May 24, 2024
View reviewed changes
Copy link
Contributor

@orxngc orxngc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your site returns a Github 404, we need a complete and accessible site.

@orxngc orxngc removed the reason: invalid file Your file is invalid or improper. label May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orxngc orxngc orxngc left review comments

@CuteDog5695 CuteDog5695 CuteDog5695 requested changes

Assignees
No one assigned
Labels
domain reason: inaccessible website Your website is not accessible to others.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@skibidiloser @CuteDog5695 @orxngc @DEV-DIBSTER