Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Pytest configuration (deprecated implicit asyncio mode) #924

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update Pytest configuration (deprecated implicit asyncio mode) #924

wants to merge 1 commit into from

Conversation

Carreau
Copy link
Member

@Carreau Carreau commented Apr 29, 2022

This make downstream test fail.

@Carreau
Copy link
Member Author

Carreau commented Apr 29, 2022

Ok, I'm confused why downstream it asks for the option and here it says the option is unknown

@blink1073
Copy link
Member

If you're referring to IPython's downstream checks, I think the check is using the pytest config from IPython itself. In the downstream-test action in jupyterlab/maintainer-tools we made sure to put the downstream folder in a separate file hierarchy to avoid this.

@Carreau
Copy link
Member Author

Carreau commented May 2, 2022

Thanks for the pointers I'll try to have a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Carreau @blink1073