reduce bitwise instructions #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did run into https://tech.popdata.org/speeding-up-Jaro-Winkler-with-rust-and-bitwise-operations/ today and since I have a similar implementation (here: https://github.com/maxbachmann/rapidfuzz-cpp/blob/main/rapidfuzz/distance/Jaro_impl.hpp) I looked into the way your implementation works.
This PR reduces the bitwise instructions used in the inner loop. Be aware, that I did not test this and do not know a ton about rust, so take this with a grain of salt.
Looking at godbolt this seems to help reduce the used instruction quite significantly:
https://rust.godbolt.org/z/dv79vfjfx
to
https://rust.godbolt.org/z/x4KdvYT36