Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency conventional-changelog-cli to v5 #5745

Merged
merged 2 commits into from
May 28, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 9, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
conventional-changelog-cli (source) ^4.0.0 -> ^5.0.0 age adoption passing confidence

Release Notes

conventional-changelog/conventional-changelog (conventional-changelog-cli)

v5.0.0

Compare Source

⚠ BREAKING CHANGES
  • Node >= 18 is required
  • cleanup presets interface (#​1215)
  • Now all packages, except gulp-conventional-changelog, are ESM-only.
Features
Bug Fixes
  • conventional-changelog-cli,conventional-recommended-bump,standard-changelog: fix config loading (#​1234) (c2c4b3a)
  • conventional-changelog-cli: fix link for option prompt (#​1159) (7e51c6d)
  • deps: update dependency meow to v13 (#​1190) (862f66b)

Configuration

📅 Schedule: Branch creation - "* 0-11 * * 1,4" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Never, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested a review from a team as a code owner May 9, 2024 03:12
@renovate renovate bot added the dependencies Pull requests that update a dependency file label May 9, 2024
Copy link
Contributor

github-actions bot commented May 9, 2024

--strictNullChecks error report

Typechecking with --strictNullChecks resulted in 1138 errors on this branch.

That's the same number of errors on main, so at least we're not creating new ones!

reports and statistics

Our most error-prone files
Path Error Count
src/dev-server/index.ts 37
src/dev-server/server-process.ts 32
src/compiler/prerender/prerender-main.ts 22
src/runtime/client-hydrate.ts 20
src/testing/puppeteer/puppeteer-element.ts 20
src/screenshot/connector-base.ts 19
src/runtime/vdom/vdom-render.ts 17
src/dev-server/request-handler.ts 15
src/compiler/prerender/prerender-optimize.ts 14
src/compiler/sys/stencil-sys.ts 14
src/sys/node/node-sys.ts 14
src/compiler/prerender/prerender-queue.ts 13
src/compiler/sys/in-memory-fs.ts 13
src/runtime/connected-callback.ts 13
src/runtime/set-value.ts 13
src/compiler/output-targets/output-www.ts 12
src/compiler/transformers/test/parse-vdom.spec.ts 12
src/compiler/transformers/transform-utils.ts 12
src/compiler/transpile/transpile-module.ts 12
src/mock-doc/test/attribute.spec.ts 12
Our most common errors
Typescript Error Code Count
TS2322 361
TS2345 344
TS18048 205
TS18047 82
TS2722 37
TS2532 24
TS2531 21
TS2454 14
TS2790 11
TS2352 9
TS2769 8
TS2538 8
TS2416 7
TS2493 3
TS18046 2
TS2684 1
TS2430 1

Unused exports report

There are 15 unused exports on this PR. That's the same number of errors on main, so at least we're not creating new ones!

Unused exports
File Line Identifier
src/runtime/bootstrap-lazy.ts 21 setNonce
src/screenshot/screenshot-fs.ts 18 readScreenshotData
src/testing/testing-utils.ts 198 withSilentWarn
src/utils/index.ts 145 CUSTOM
src/utils/index.ts 245 NODE_TYPES
src/utils/index.ts 269 normalize
src/utils/index.ts 7 escapeRegExpSpecialCharacters
src/compiler/app-core/app-data.ts 25 BUILD
src/compiler/app-core/app-data.ts 116 Env
src/compiler/app-core/app-data.ts 118 NAMESPACE
src/compiler/fs-watch/fs-watch-rebuild.ts 123 updateCacheFromRebuild
src/compiler/types/validate-primary-package-output-target.ts 61 satisfies
src/compiler/types/validate-primary-package-output-target.ts 61 Record
src/testing/puppeteer/puppeteer-declarations.ts 485 WaitForEventOptions
src/compiler/sys/fetch/write-fetch-success.ts 7 writeFetchSuccessSync

Copy link
Contributor

github-actions bot commented May 9, 2024

PR built and packed!

Download the tarball here: https://github.com/ionic-team/stencil/actions/runs/9273155642/artifacts/1545109095

If your browser saves files to ~/Downloads you can install it like so:

unzip -d ~/Downloads ~/Downloads/stencil-core-4.18.2-dev.1716914344.5893a0a.tgz.zip && npm install ~/Downloads/stencil-core-4.18.2-dev.1716914344.5893a0a.tgz

@christian-bromann
Copy link
Member

In regards to the breaking changes:

  • Node >= 18 is required

This is fine as this package is a development package and for development we have defined Node.js v22.2.0.

I don't think this will impact us as we only use the package through its CLI.

  • Now all packages, except gulp-conventional-changelog, are ESM-only.

This will not impact us as we only use the package through its CLI.

@christian-bromann christian-bromann force-pushed the renovate/conventional-changelog-cli-5.x branch from fe1cce1 to 23348b4 Compare May 28, 2024 16:20
Copy link
Contributor Author

renovate bot commented May 28, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@christian-bromann christian-bromann merged commit 13f04e7 into main May 28, 2024
92 of 93 checks passed
@christian-bromann christian-bromann deleted the renovate/conventional-changelog-cli-5.x branch May 28, 2024 16:45
christian-bromann added a commit that referenced this pull request May 28, 2024
christian-bromann added a commit that referenced this pull request May 28, 2024
github-merge-queue bot pushed a commit that referenced this pull request May 28, 2024
* Revert "chore(deps): update dependency conventional-changelog-cli to v5 (#5745)"

This reverts commit 13f04e7.

* fix conventional build script generation

* Revert "Revert "chore(deps): update dependency conventional-changelog-cli to v5 (#5745)""

This reverts commit 0f99858.

* fix pkg commands
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant