-
Notifications
You must be signed in to change notification settings - Fork 767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(compiler): support rollup's external input option #3227
base: main
Are you sure you want to change the base?
Conversation
Pluck the external option from the stencil config and pass it through to rollup.
Thanks for this PR! I see the accompanying issue and have labeled this PR for the team to take a look at both a little more closely. |
@rwaskiewicz Do you have an update on the process for this PR ? Any outstanding questions or issues? |
@awk I think the next steps for this PR is for the team to sit down and review the PR. Specifically, we'll be looking at the changes and convincing ourselves that it doesn't conflict with any internal rollup configuration Stencil currently does. While I can't promise an exact timeline, we'll take a look as soon as we get a chance! |
In the mean time, I've enabled the rest of CI to run for this PR to make sure the rest of our checks pass |
@rwaskiewicz Are there any updates on @awk 's PR? This would also be a very important feature for a project we're developing |
This would be nice to include. The current workaround I'm using is based on this but with a slight modification:
|
Pluck the external option from the stencil config and pass it through to rollup.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build
) was run locally and any changes were pushednpm test
) were run locally and passednpm run test.karma.prod
) were run locally and passednpm run prettier
) was run locally and passedPull request type
Please check the type of change your PR introduces:
What is the current behavior?
GitHub Issue Number: #3226
What is the new behavior?
The
external
option is now supported and works when added to the rollupConfig.inputOptionsDoes this introduce a breaking change?
Testing
In my project (private - sorry) which has a complex set of module dependencies I can see that the desired module is no longer included in the stencil output.
Other information