-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update playwright to v1.44.0 #29470
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@thetaPC I wouldn't merge this as-is. The playwright version for the docker image should match the project dependency and renovate should be grouping those dependency updates: ionic-framework/renovate.json5 Lines 24 to 40 in 88db938
I would have expected a bump to the lock file for the |
334332d
to
81c9e21
Compare
This might have something to do with the age of the dependency. I ran into the same problem on a personal repo. Your renovatebot config requires a minimum release age of 3 days. This version of Playwright only came out yesterday, so the npm dependency has not met the min 3 day requirement. I would have expected the same to be true for the Docker dependency, but maybe minimumReleaseAge works differently/is not supported with Docker deps? |
I need to dig a bit deeper into this. Yesterday I was able to verify through the Renovate logs that it sees that Playwright needs to be updated. But it never commits to it. So the 3 day minimum mentioned by @liamdebeasi might not be related. |
81c9e21
to
3c41f53
Compare
Based on my investigation, the renovate config needs to be modified. The current setup is allowing any package within the group to upgrade regardless if not all of them are ready. This GH discussions provides an example of how we should go about it. I'll open a separate PR to test it further. In the meantime, Playwright finally updated after the 3 days minimum as mentioned so we can proceed. The hold up is that some tests are failing. I was able to identify one of the issues is due to Playwright upgrading Chrome, which now has datetime acting differently when font size is scaling. This is actually good because now it behaves like the other browsers. |
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR contains the following updates:
1.43.1
->1.44.0
v1.43.1
->v1.44.0
Release Notes
microsoft/playwright (@playwright/test)
v1.44.0
Compare Source
New APIs
Accessibility assertions
expect(locator).toHaveAccessibleName() checks if the element has the specified accessible name:
expect(locator).toHaveAccessibleDescription() checks if the element has the specified accessible description:
expect(locator).toHaveRole() checks if the element has the specified ARIA role:
Locator handler
noWaitAfter
option.times
option in page.addLocatorHandler() to specify maximum number of times the handler should be run.Miscellaneous options
multipart
option inapiRequestContext.fetch()
now acceptsFormData
and supports repeating fields with the same name.expect(callback).toPass({ intervals })
can now be configured byexpect.toPass.inervals
option globally in testConfig.expect or per project in testProject.expect.expect(page).toHaveURL(url)
now supportsignoreCase
option.testProject.ignoreSnapshots allows to configure per project whether to skip screenshot expectations.
Reporter API
outputFile
. The same option can also be specified asPLAYWRIGHT_BLOB_OUTPUT_FILE
environment variable that might be more convenient on CI/CD.includeProjectInTestName
option.Command line
--last-failed
CLI option for running only tests that failed in the previous run.First run all tests:
$ npx playwright test Running 103 tests using 5 workers ... 2 failed [chromium] › my-test.spec.ts:8:5 › two ───────────────────────────────────────────────────────── [chromium] › my-test.spec.ts:13:5 › three ────────────────────────────────────────────────────── 101 passed (30.0s)
Now fix the failing tests and run Playwright again with
--last-failed
option:$ npx playwright test --last-failed Running 2 tests using 2 workers 2 passed (1.2s)
Browser Versions
This version was also tested against the following stable channels:
Configuration
📅 Schedule: Branch creation - "every weekday before 11am" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Never, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR has been generated by Mend Renovate. View repository job log here.