Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update playwright to v1.44.0 #29470

Merged
merged 2 commits into from
May 17, 2024
Merged

chore(deps): update playwright to v1.44.0 #29470

merged 2 commits into from
May 17, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 7, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence Type Update
@playwright/test (source) 1.43.1 -> 1.44.0 age adoption passing confidence devDependencies minor
mcr.microsoft.com/playwright v1.43.1 -> v1.44.0 age adoption passing confidence final minor

Release Notes

microsoft/playwright (@​playwright/test)

v1.44.0

Compare Source

New APIs

Accessibility assertions

  • expect(locator).toHaveAccessibleName() checks if the element has the specified accessible name:

    const locator = page.getByRole('button');
    await expect(locator).toHaveAccessibleName('Submit');
  • expect(locator).toHaveAccessibleDescription() checks if the element has the specified accessible description:

    const locator = page.getByRole('button');
    await expect(locator).toHaveAccessibleDescription('Upload a photo');
  • expect(locator).toHaveRole() checks if the element has the specified ARIA role:

    const locator = page.getByTestId('save-button');
    await expect(locator).toHaveRole('button');

Locator handler

  • After executing the handler added with page.addLocatorHandler(), Playwright will now wait until the overlay that triggered the handler is not visible anymore. You can opt-out of this behavior with the new noWaitAfter option.
  • You can use new times option in page.addLocatorHandler() to specify maximum number of times the handler should be run.
  • The handler in page.addLocatorHandler() now accepts the locator as argument.
  • New page.removeLocatorHandler() method for removing previously added locator handlers.
const locator = page.getByText('This interstitial covers the button');
await page.addLocatorHandler(locator, async overlay => {
  await overlay.locator('#close').click();
}, { times: 3, noWaitAfter: true });
// Run your tests that can be interrupted by the overlay.
// ...
await page.removeLocatorHandler(locator);

Miscellaneous options

  • multipart option in apiRequestContext.fetch() now accepts FormData and supports repeating fields with the same name.

    const formData = new FormData();
    formData.append('file', new File(['let x = 2024;'], 'f1.js', { type: 'text/javascript' }));
    formData.append('file', new File(['hello'], 'f2.txt', { type: 'text/plain' }));
    context.request.post('https://example.com/uploadFiles', {
      multipart: formData
    });
  • expect(callback).toPass({ intervals }) can now be configured by expect.toPass.inervals option globally in testConfig.expect or per project in testProject.expect.

  • expect(page).toHaveURL(url) now supports ignoreCase option.

  • testProject.ignoreSnapshots allows to configure per project whether to skip screenshot expectations.

Reporter API

  • New method suite.entries() returns child test suites and test cases in their declaration order. suite.type and testCase.type can be used to tell apart test cases and suites in the list.
  • Blob reporter now allows overriding report file path with a single option outputFile. The same option can also be specified as PLAYWRIGHT_BLOB_OUTPUT_FILE environment variable that might be more convenient on CI/CD.
  • JUnit reporter now supports includeProjectInTestName option.

Command line

  • --last-failed CLI option for running only tests that failed in the previous run.

    First run all tests:

    $ npx playwright test
    
    Running 103 tests using 5 workers
    ...
    2 failed
      [chromium] › my-test.spec.ts:8:5 › two ─────────────────────────────────────────────────────────
      [chromium] › my-test.spec.ts:13:5 › three ──────────────────────────────────────────────────────
    101 passed (30.0s)

    Now fix the failing tests and run Playwright again with --last-failed option:

    $ npx playwright test --last-failed
    
    Running 2 tests using 2 workers
      2 passed (1.2s)

Browser Versions

  • Chromium 125.0.6422.14
  • Mozilla Firefox 125.0.1
  • WebKit 17.4

This version was also tested against the following stable channels:

  • Google Chrome 124
  • Microsoft Edge 124

Configuration

📅 Schedule: Branch creation - "every weekday before 11am" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Never, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

Copy link

vercel bot commented May 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2024 8:36pm

@renovate renovate bot requested a review from a team as a code owner May 7, 2024 00:52
@renovate renovate bot requested a review from thetaPC May 7, 2024 00:52
@github-actions github-actions bot added the package: core @ionic/core package label May 7, 2024
@sean-perkins
Copy link
Contributor

sean-perkins commented May 7, 2024

@thetaPC I wouldn't merge this as-is. The playwright version for the docker image should match the project dependency and renovate should be grouping those dependency updates:

{
matchDatasources: ["npm"],
matchPackagePatterns: ["@playwright/test", "@axe-core/playwright"],
groupName: "playwright",
matchFileNames: [
"core/package.json"
]
},
{
matchDatasources: ["docker"],
matchPackageNames: ["mcr.microsoft.com/playwright"],
groupName: "playwright",
matchFileNames: [
"core/Dockerfile"
],
versioning: "semver"
},

I would have expected a bump to the lock file for the core package to @playwright/test.

@liamdebeasi
Copy link
Contributor

liamdebeasi commented May 8, 2024

This might have something to do with the age of the dependency. I ran into the same problem on a personal repo. Your renovatebot config requires a minimum release age of 3 days. This version of Playwright only came out yesterday, so the npm dependency has not met the min 3 day requirement.

I would have expected the same to be true for the Docker dependency, but maybe minimumReleaseAge works differently/is not supported with Docker deps?

@thetaPC
Copy link
Contributor

thetaPC commented May 9, 2024

I need to dig a bit deeper into this. Yesterday I was able to verify through the Renovate logs that it sees that Playwright needs to be updated. But it never commits to it. So the 3 day minimum mentioned by @liamdebeasi might not be related.

@renovate renovate bot changed the title chore(deps): update mcr.microsoft.com/playwright docker tag to v1.44.0 chore(deps): update playwright to v1.44.0 May 13, 2024
@thetaPC
Copy link
Contributor

thetaPC commented May 16, 2024

Based on my investigation, the renovate config needs to be modified. The current setup is allowing any package within the group to upgrade regardless if not all of them are ready. This GH discussions provides an example of how we should go about it. I'll open a separate PR to test it further.

In the meantime, Playwright finally updated after the 3 days minimum as mentioned so we can proceed.

The hold up is that some tests are failing. I was able to identify one of the issues is due to Playwright upgrading Chrome, which now has datetime acting differently when font size is scaling. This is actually good because now it behaves like the other browsers.

Copy link
Contributor Author

renovate bot commented May 17, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thetaPC thetaPC added this pull request to the merge queue May 17, 2024
Merged via the queue into main with commit 7c56eb7 May 17, 2024
48 checks passed
@thetaPC thetaPC deleted the renovate/playwright branch May 17, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants