Separate single session queue item processing into its own class #5870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
python
…r into its own class
… doing, add before/after callbacks for sessions
…stract class for session runners, create path for passing in custom session runner to default session processor
brandonrising
force-pushed
the
separate-graph-execution-loop
branch
from
171b889
to
71ee28a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Have you discussed this change with the InvokeAI team?
Have you updated all relevant documentation?
Description
The current session queue processor combines managing the session queue and running a graph on each item into a single class. This PR separates the two concerns into their own Classes to remove the likelihood of editing one affecting the other. Also if anyone chooses to not use the default processor, they can do it without rewriting the logic that actually runs invocations.
QA Instructions, Screenshots, Recordings
Will update before converting to PR
Merge Plan
This PR can be merged when approved
Added/updated tests?
have not been included