Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add QueryExpression.LENGTH and QueryExpression.CONCAT operators #2306

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

Add QueryExpression.LENGTH and QueryExpression.CONCAT operators #2306

wants to merge 6 commits into from

Conversation

sammyjava
Copy link
Member

@sammyjava sammyjava commented Dec 2, 2020

Details

This adds the LENGTH and CONCAT operators to QueryExpression, which can be useful. They were for me. :)

Testing

This update has been in production on the LIS mines for quite a while.

Checklist

Before your pull request can be approved, be sure to check all boxes:

  • Passing unit test for new or updated code (if applicable)
  • Passes all tests – according to Travis
  • Documentation (if applicable)
  • Single purpose
  • Detailed commit messages
  • Well commented code
  • Checkstyle

@sammyjava
Copy link
Member Author

Note: this shows three commits, but the first two are a forward and backward commit because I did a previous update on dev rather than creating a new branch as I should. The six files that are changed are indeed the six files that belong to this PR.

@sammyjava
Copy link
Member Author

@danielabutano I need someone that understands the query testing system to fix the Travis test errors. I'm completely confused about where the error occurs and why. I've tried a couple times to fix it but I'm stabbing in the dark. Thanks. :) Not a high-priority PR in any case.

@danielabutano
Copy link
Member

danielabutano commented Dec 3, 2020

@sammyjava at the moment is the checkstyle which is failing, the tests have not been executed yet (the tests are executed after the checkstyle check). Looking at the commit you did, I noticd a lot of spaces not required or identation issues
I would suggest to fix the checkstyle first.
If you run ./gradlew checkstyleMain you can see locally what went wrong

@sammyjava
Copy link
Member Author

@danielabutano Working on the checkstyle, but I know that I'll not be able to fix these subtle tests on the new query expressions. At least not without a massive amount of study. :) But I'll get the checkstyle cleaned up so that's all that's left.

@sammyjava
Copy link
Member Author

@danielabutano I fixed checkstyle, but it'll still error on the tests which mystify me. But it's ready for someone who understands those tests to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants