Fixes to CMakeLists #294
Open
Fixes to CMakeLists #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The usage of CMAKE_CURRENT_SOURCE_DIR and CMAKE_CURRENT_BINARY_DIR is encouraged over the use of CMAKE_SOURCE_DIR and CMAKE_BINARY_DIR respectivly. In addition, bump the required minimum version to 3.0 to avoid warnings about the old version 2. CMAKE_MODULE_PATH is not a variable to hold a specific directory. Instead, add the cmake directory which holds the hyperscan-specific CMake modules to CMAKE_MODULE_PATH and replace its usages. include() directives can now simply use the filename (it is picked up without the .cmake extension, because we added the directory to the module path). The remaining usages where the exact directory was referenced are replaced with $PROJECT_SOURCE_DIR/cmake, although one could probably even use a new variable for that directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The usage of CMAKE_CURRENT_SOURCE_DIR and CMAKE_CURRENT_BINARY_DIR is
encouraged over the use of CMAKE_SOURCE_DIR and CMAKE_BINARY_DIR
respectivly.
In addition, bump the required minimum version to 3.0 to avoid warnings
about the old version 2.
CMAKE_MODULE_PATH is not a variable to hold a specific directory.
Instead, add the cmake directory which holds the hyperscan-specific
CMake modules to CMAKE_MODULE_PATH and replace its usages. include()
directives can now simply use the filename (it is picked up without the
.cmake extension, because we added the directory to the module path).
The remaining usages where the exact directory was referenced are
replaced with $PROJECT_SOURCE_DIR/cmake, although one could probably
even use a new variable for that directory.