Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMAKE_BUILD_TYPE case fix #233

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

traceon
Copy link

@traceon traceon commented Apr 23, 2020

  • Do not convert CMAKE_BUILD_TYPE to upper case in-place
    • Causes problems in some generators (Ninja), that construct internal target names based on this value, and sometimes, when this project is included using add_directory(), case mismatch may occur for different references to the same internal targets
    • Not a good idea to modify case in-place, it is just as unsafe as it looks...
  • Use CMAKE_CONFIGURATION_TYPES converted to upper case when deducing build type dependent vars
    • CMAKE_C_FLAGS_RelWithDebInfo is not the same as CMAKE_C_FLAGS_RELWITHDEBINFO, so addressed that too here

Use CMAKE_CONFIGURATION_TYPES converted to upper case when deducing build type dependent vars
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant