Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hscollider build on alpine linux #134

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix hscollider build on alpine linux #134

wants to merge 1 commit into from

Conversation

smlx
Copy link

@smlx smlx commented Feb 6, 2019

_exit() is defined in <unistd.h> as per POSIX.

I don't have access to a Windows box so can't test the build on that platform.

_exit() is defined in <unistd.h> as per POSIX.
@carenas
Copy link
Contributor

carenas commented Jun 4, 2019

while the proposed code does "fix" the build it doesn't address the root cause (which was that the header needed for _exit() was being included through the wrong dependency, and the test for it was never used), moving instead the dependency to another flag that also happens to work for alpine linux

and alternative solution is to install libexecinfo-dev in alpine so the logic that was originally added for FreeBSD can do its magic, instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants