Fix oper override message when viewing a list mode

[B00mX0r]

Currently, oper override executes a MODE override attempt every time a MODE command with a higher adding level than the user has is run. Consequently, this results in an oper override announcement showing when an oper simply did /mode #chan +b to view a list mode rather than modify it.

Because the m_hidelist module explicitly provides for a channels/auspex permission to bypass its restrictions, it is outside of oper override's jurisdiction to touch or care about list modes. This PR makes oper override completely ignore viewing list modes, meaning that a MODE override permission will not replace m_hidelist's channels/auspex requirement for a bypass, and that an oper innocently viewing a listmode will not trigger the override announcement.

This fixes #425.

[SadieCat]

Hey,

Sorry for taking so long to review this. It seems like I managed to miss it.

Oper override would execute for MODE every time a mode in the command had an "adding" permission higher than the user's current permission. This would result in an oper override announcement showing when an oper simply did /mode #chan +b.

Sending an override announcement is valid behaviour when overriding <security:hidemodes>. The issue is that sometimes when an oper views a channel's list modes it does not take into account whether the oper's access in that channel is high enough to allow them to list modes without overriding. In such a case no message should be sent.

Because hideopers gives channels/auspex permission to bypass it, this patch does not use oper override to override the viewing of list modes with hideopers in place.

The hideopers module does not use channels/auspex. It does use users/auspex but only in the context of checking whether an oper can override hideoper which is not relevant to the override module.

[B00mX0r]

@SaberUK My sincere apologies. The PR description was wrong, as I accidentally referred to the incorrect module. I have rewritten the description to properly reflect the changes that this PR implements.

[SadieCat]

HideListEventListwnwe.

[SadieCat]

Update the code documentation too.

[SadieCat]

Pass a list mode handler here instead of just the name.

[B00mX0r]

We don't have this information in the ModeWatcher class. Also, the mode name just needs to be passed for the m_override snomask announcement.

[B00mX0r]

I renamed OnListDenied to OnListDeny to better reflect that the denial is dependent on the MOD_RESULT from this call.

[B00mX0r]

Targeting v3 instead of v2 because it's in RC stage now