Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.0] m_override reports non-overrides #425

Closed
satmd opened this issue Feb 15, 2013 · 6 comments · May be fixed by #1418
Closed

[2.0] m_override reports non-overrides #425

satmd opened this issue Feb 15, 2013 · 6 comments · May be fixed by #1418
Labels
bug Something isn't working need more information Further information is requested

Comments

@satmd
Copy link
Contributor

satmd commented Feb 15, 2013

m_override will report a /mode #channel b regardless of permissions required.

The issue stems from m_override, line 108 being overly strict and not taking into account individual modes' levelrequired.

Suggestion: Before line 108, filter out modes that could have been done without override correctly.

@HelixSpiral
Copy link
Contributor

Could prioritize it last and only do stuff if mod_res == mod_res_deny or something.

@satmd
Copy link
Contributor Author

satmd commented Feb 15, 2013

In that case, the module being overriden will send out reject messages

@B00mX0r
Copy link
Contributor

B00mX0r commented Feb 3, 2015

It appears to be for any listmode (+g, +e, etc). I noticed that you didn't specify this.

@SadieCat
Copy link
Member

I'm having trouble replicating this against the current 2.0 git. Is it still an issue for you?

@genius3000
Copy link
Member

genius3000 commented Aug 24, 2018

I just updated my net to current 2.0 git a few days ago and still see this. Joining user's client requests ban list (allowed) but as override capable oper, it's shown as override. Not just on join, /mode #chan b will trigger the override notice too. Yes, a regular user is allowed to view the ban list on my net (verified).
I believe this is what #1418 is for.

@Robby-
Copy link
Contributor

Robby- commented Oct 17, 2018

I just ran into this issue as well. One network logged an override, while the other didn't. It turns out the difference was in the <type:override> setting. On one network its set as <type:override="*"> and on the other its set as <type:override="INVITE KEY LIMIT BANWALK">. The first one with * logs the override, while the latter one with the list of overrides does not log an override when doing a /MODE #channel b, but that is because it does not have MODE in that list. This of course makes perfect sense but was confusing me at first as indeed no override should be logged for simply viewing listmode lists.

However, upon reading the thread of #1418, for opers that do have MODE (or *), this should still be logged for modes hidden with <security:hidemodes>, as appropriate.

@satmd satmd closed this as completed Apr 12, 2020
SadieCat pushed a commit to SadieCat/inspircd that referenced this issue Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working need more information Further information is requested
Development

Successfully merging a pull request may close this issue.

6 participants