Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add m_hash_crypt module #246

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Add m_hash_crypt module #246

wants to merge 10 commits into from

Commits on Nov 28, 2020

  1. Implement m_hash_crypt 

    This is a crypt(3)-based hash function for compatibility with Unix crypt
and other IRC daemons that use it. This relies on the system crypt which
may unfortunately be deficient, hence there are ugly ifdef's.
    @Elizafox
    Elizafox committed Nov 28, 2020
    Configuration menu
    Copy the full SHA
    fcae848 View commit details
    Browse the repository at this point in the history

  2. Try to fix the build on macOS (and others)

    @Elizafox
    Elizafox committed Nov 28, 2020
    Configuration menu
    Copy the full SHA
    4df2202 View commit details
    Browse the repository at this point in the history

  3. Add a rather crappy heuristic test for libcrypt 

    Turns out that you can't depend on pkg-config just picking up -lcrypt
everywhere. It doesn't work on my Debian box for example.
    @Elizafox
    Elizafox committed Nov 28, 2020
    Configuration menu
    Copy the full SHA
    ec166f8 View commit details
    Browse the repository at this point in the history

  4. Fix the self-test

    @Elizafox
    Elizafox committed Nov 28, 2020
    Configuration menu
    Copy the full SHA
    d66ef4b View commit details
    Browse the repository at this point in the history

  5. Make hack in m_hash_crypt a lot less hacky. 

    Basically, we know that linux, freebsd, and netbsd require -lcrypt.
openbsd and darwin don't (and the build will fail on at least macos if
we add that flag). So, add the known systems to the LinkerFlags and go
on our merry way.

The reason we can't use pkg-config is because libcrypt-dev is not widely
available yet (Debian stale notably does not have it) and operating
systems like FreeBSD are unlikely to really ever have it.
    @Elizafox
    Elizafox committed Nov 28, 2020
    Configuration menu
    Copy the full SHA
    1b3aa88 View commit details
    Browse the repository at this point in the history

  6. Remove explicit support for md5, blowfish, and DES 

    These are insecure and should not be generated.

crypt-generic is introduced instead, for access to the system crypt
directly. This shouldn't be used to generate passwords, but can be used
for password checking.
    @Elizafox
    Elizafox committed Nov 28, 2020
    Configuration menu
    Copy the full SHA
    6696dcb View commit details
    Browse the repository at this point in the history

  7. Improve self-tests

    @Elizafox
    Elizafox committed Nov 28, 2020
    Configuration menu
    Copy the full SHA
    2fda1ee View commit details
    Browse the repository at this point in the history

  8. Fix names per @genius3000

    @Elizafox
    Elizafox committed Nov 28, 2020
    Configuration menu
    Copy the full SHA
    4455a07 View commit details
    Browse the repository at this point in the history

  9. Please the C++98 gods.

    @Elizafox
    Elizafox committed Nov 28, 2020
    Configuration menu
    Copy the full SHA
    404d451 View commit details
    Browse the repository at this point in the history

  10. Comment improvements.

    @Elizafox
    Elizafox committed Nov 28, 2020
    Configuration menu
    Copy the full SHA
    b3d7458 View commit details
    Browse the repository at this point in the history