Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support launch templates references which use prefix #3069

Merged
merged 1 commit into from
May 15, 2024
Merged

Conversation

hugorut
Copy link
Contributor

@hugorut hugorut commented May 15, 2024

This PR adds support for launch templates which are referenced by name in a resource but use a prefix to launch. This means that the name attribute can be null and prior to this change, references would not work. This change adds a Infracost generated name if it is detected that the launch_template has a null name.

This PR adds support for launch templates which are referenced by `name` in
a resource but use a `prefix` to launch. This means that the `name` attribute
can be `null` and prior to this change, references would not work. This change
adds a Infracost generated `name` if it is detected that the `launch_template`
has a `null` name.
Copy link
Member

@aliscott aliscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat fix

@hugorut hugorut merged commit 5df9774 into master May 15, 2024
9 of 10 checks passed
@hugorut hugorut deleted the IC-1144 branch May 15, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants