Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return MergeIterator.Close errors (#24975) #24997

Merged
merged 1 commit into from May 14, 2024

Conversation

davidby-influx
Copy link
Contributor

Ensure that errors from closing the
iterators underneath a MergeIterator
are returned up the stack.

(cherry picked from commit 5fda409)

closes #24977

Ensure that errors from closing the
iterators underneath a MergeIterator
are returned up the stack.

(cherry picked from commit 5fda409)

closes #24977
Copy link
Member

@gwossum gwossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidby-influx davidby-influx merged commit a97566b into main-2.x May 14, 2024
25 checks passed
@davidby-influx davidby-influx deleted the DSB_iterator_close_2.x branch May 14, 2024 01:27
davidby-influx added a commit that referenced this pull request May 14, 2024
Ensure that errors from closing the
iterators underneath a MergeIterator
are returned up the stack.

(cherry picked from commit 5fda409)

closes #24977

(cherry picked from commit a97566b)

closes #24978
davidby-influx added a commit that referenced this pull request May 14, 2024
Ensure that errors from closing the
iterators underneath a MergeIterator
are returned up the stack.

(cherry picked from commit 5fda409)

closes #24977

(cherry picked from commit a97566b)

closes #24978
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants