-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use scikit-build-core #755
Conversation
512034a
to
29203be
Compare
29203be
to
a19d21f
Compare
a661602
to
e41aa50
Compare
b184ce1
to
bc89a30
Compare
If we want to switch, why not |
TIL, thanks! I think the main reason for using |
0458d9a
to
df25566
Compare
df25566
to
82a6e79
Compare
This seems to work fine and is ready for a first look @inducer. I'm not sure what the best way to replace/reimplement the |
What functionality exactly? Generally the configuration can be done in
|
Co-authored-by: Alex Fikl <alexfikl@gmail.com>
Co-authored-by: Alex Fikl <alexfikl@gmail.com>
I've pushed the branch to Gitlab to check CI there (added a link to the description for easy access). While |
I think the 'downstream' Gitlab tests should be fixed now ('examples'/'K40' tests fail with |
Not sure what's going on with the boxtree test (failure seems to be spurious?), but gitlab tests seem to be fixed. |
We can't really get a clean test run on Gitlab because of inducer/pytools#227, so I'll put this on hold until we can. |
Nvm, we can, now that the release is yanked. |
LGTM. Thanks for making this happen. Let's do it! |
This appears to fix #753.
TODO:
Please squash