fix: Refactor Layered Architecture pattern #2936 #2938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Let me know when it's ready for review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Ecco un possibile testo che potresti aggiungere nella tua pull request:
What problem does this PR solve?
This PR addresses a couple of specific issues in the Layered Architecture code example (#2936):
Main Entry Point for Runner.java: Runner.java lacked a main entry point, preventing it from being executed directly in an IDE. This PR adds a
mainmethod to Runner.java to resolve this issue.Warnings Regarding Optional Usage: There were warnings related to the usage of
Optionalas a type for theidfield in the classesCakeInfo,CakeLayerInfo, andCakeToppingInfo. The use ofOptionalfor fields is generally discouraged, asOptionalis primarily intended for method return types where there is a need to represent "no result" without using null.I'm relatively new to contributing and may have misunderstood or not fully addressed the issues. If there are any mistakes or if further changes are needed, please let me know. Apologies for any inconvenience caused.