Log running commands and setting options and properties #4926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit will: - Change PlayerCore to pass the value of playerCoreCounter when creating the MPVController object - Change MPVController to use a logger subsystem name that includes the counter to identify the player the instance is associated with - Change MPVController to log commands sent to mpv - Change MPVController to log setting of mpv options and properties
1 task
|
Very useful feature! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit will:
Change
PlayerCoreto pass the value ofplayerCoreCounterwhen creating theMPVControllerobjectChange
MPVControllerto use a logger subsystem name that includes the counter to identify the player the instance is associated withChange
MPVControllerto log commands sent to mpvChange
MPVControllerto log setting of mpv options and propertiesI have read CONTRIBUTING.md
This implements/fixes issue #.
Description: