New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle the invalid date the same way moment.js does, with and without the utc plugin #2574

Open

AntonRunDev wants to merge 2 commits into iamkun:dev from AntonRunDev:feature/handle_invalid_date

AntonRunDev commented Feb 9, 2024

The goal of this PR is to provide consistent behavior compared to moment js.

In momentjs the dayjs('invalid').toISOString() -> returns null

But in dayjs the dayjs('invalid').toISOString() -> throws an error
The desired behavior is to also return null.

The PR changes apply to both cases, whether you use the utc plugin or not

Anton and others added 2 commits

February 9, 2024 12:55


          Handle the invalid date the same way moment.js does, with and without…

2ec620e

… the utc plugin


          Merge branch 'dev' into feature/handle_invalid_date

195cbd1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment